fix: Fix tile flips when using canvas.drawAtlas #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
requested review from
luanpotter,
spydon,
wolfenrain,
erickzanardo and
renancaraujo
spydon
approved these changes
May 7, 2022
spydon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes changes to SpriteBatch to deal with flipped tiles. Specifically since RSTransform and therefore drawAtlas isn't able to handle flips this PR feeds an additional flipped version of the atlas to the SpriteBatch. Since this could create an additional image per flip type (H + V), flips have been simplified to reduce that to just a horizontally flipped image. All vertical flips (+rotations) can be represented as horizontal flips +180º.
The SimpleFlips class has been updated to represent this even simpler representation of angles and flips. This is the only breaking change in this PR.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Related Issues
Fixes issue listed at top of package README