feat!: Added anchor for the Viewport #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
requested review from
spydon,
erickzanardo,
luanpotter,
renancaraujo and
wolfenrain
spydon
approved these changes
May 8, 2022
luanpotter
reviewed
May 8, 2022
luanpotter
reviewed
May 8, 2022
Comment on lines
+114
to
+117
| final viewportPoint = Vector2( | ||
| point.x - viewport.position.x + viewport.anchor.x * viewport.size.x, | ||
| point.y - viewport.position.y + viewport.anchor.y * viewport.size.y, | ||
| ); |
There was a problem hiding this comment.
is this the same as: point - anchor.translate(viewport.position, viewport.size) ?
There was a problem hiding this comment.
Could be, but I don't really understand what is anchor.translate(), and when it can be used.
luanpotter
reviewed
May 8, 2022
| canvas.translate( | ||
| viewport.position.x - viewport.anchor.x * viewport.size.x, | ||
| viewport.position.y - viewport.anchor.y * viewport.size.y, | ||
| ); |
There was a problem hiding this comment.
is this the same as canvas.translateVector(anchor.translate(viewport.position, viewport.size)?
we could even have a function to combine an anchor and a viewport that calls anchor.translate
wolfenrain
approved these changes
May 8, 2022
erickzanardo
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Viewportnow has its own anchor;Viewportnow always has the origin in the top-left corner of its bounding box (previously it was in the center) -- similar to the local coordinate system of aPositionComponent.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Related Issues