feat: method componentsAtPoint now reports the "stacktrace" of points
#1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
requested review from
spydon,
wolfenrain,
erickzanardo,
luanpotter and
renancaraujo
| /// element in the list is the point in the coordinate space of the returned | ||
| /// component, the element before the last is in that component's parent's | ||
| /// coordinate space, and so on. The [nestedPoints] list must be growable and | ||
| /// modifiable. |
There was a problem hiding this comment.
list must be growable and modifiable
Can't we clone the list to avoid this type of side effect? Or does this gives a huge impact on perfomance?
If so, we could at least clone at on the first call?
There was a problem hiding this comment.
It is an output parameter, so the entire idea is that the list will be modified by the function so that the user would then be able to look at it.
wolfenrain
changed the title
componentsAtPoint now reports the "stacktrace" of points
wolfenrain
reviewed
May 11, 2022
It's not, because we haven't released those changes. :) |
spydon
approved these changes
May 11, 2022
wolfenrain
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The method
componentsAtPointnow has an optional parameternestedPoints, which will record the "stacktrace" of points up to and including the currently returned component. This allows for better flexibility in understanding the point's position relative to its parent and the world. This also allows the methodcomponentsAtPointto return an iterable ofComponents instead of an iterable ofComponentPointPairs.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
componentsAtPoint(). However, since the method itself was only introduced 2 weeks ago (feat: Added componentsAtPoint() iterable #1518), and there hasn't been a Flame release since then, the change can be considered non-breaking.Related Issues
Closes #1592