Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add helper function for creating golden tests #1623

Merged
merged 6 commits into from
May 15, 2022
Merged

feat: Add helper function for creating golden tests #1623

merged 6 commits into from
May 15, 2022

Conversation

st-pasha
Copy link
Contributor

Description

Added new function testGolden() that reduces the boilerplate of writing golden tests to a minimum.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples.

Breaking Change

  • [-] Yes, this is a breaking change.
  • No, this is not a breaking change.

spydon
spydon approved these changes May 14, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

packages/flame_test/lib/src/test_golden.dart Show resolved Hide resolved
@spydon
Copy link
Member

spydon commented May 15, 2022

The scope that you add in the conventional commit tag doesn't have to be the package, Melos already figures that out. The scope is more to group things belonging to the same epic I think, like the text one you created.

@st-pasha st-pasha changed the title feat(flame_test): Add helper function for creating golden tests feat: Add helper function for creating golden tests May 15, 2022
@spydon spydon enabled auto-merge (squash) May 15, 2022 20:48
@spydon spydon merged commit d0faaad into flame-engine:main May 15, 2022
@st-pasha st-pasha deleted the ps/golden branch May 15, 2022 21:07
st-pasha added a commit to st-pasha/flame that referenced this pull request May 16, 2022
@st-pasha
feat: Add helper function for creating golden tests (flame-engine#1623)
d40c64b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfenrain wolfenrain wolfenrain approved these changes

@spydon spydon spydon approved these changes

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

@luanpotter luanpotter Awaiting requested review from luanpotter

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@st-pasha @spydon @wolfenrain