Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flame_lint): Upgrade dartdoc (upgrade analyzer transitive dependency) #1630

Merged
merged 2 commits into from
May 15, 2022

Conversation

Gustl22
Copy link
Contributor

@Gustl22 Gustl22 commented May 15, 2022

Description

Flutter 3 doesn't like the old danalyzer dependency:

flame_lint 0.0.1
'-- dartdoc 4.1.0
    |-- analyzer 2.8.0

which leads to the following error, when executing melos bootstrap:

[audioplayers]: ERR : Rename failed, path = 'C:\hostedtoolcache\windows\flutter\3.0.0-stable\x64\.pub-cache\_temp\dir1cbe5ff7' (OS Error: Cannot create a file when that file already exists.

While dir1cbe5ff7 is the temporary folder for flame_lint

We can also consider remove dartdocs dependency completely, if its not needed elsewhere.
Plz also consider publishing soon, as audioplayers Merge-Requests depend on it.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Just currently occurs in windows tests for audioplayers, when calling melos bootstrap

@Gustl22 Gustl22 changed the title fix: Upgrade dartdoc (upgrade analyzer transitive dependency) fix(flame_lint): Upgrade dartdoc (upgrade analyzer transitive dependency) May 15, 2022
@spydon spydon enabled auto-merge (squash) May 15, 2022 14:46
@spydon spydon merged commit 6da8adb into flame-engine:main May 15, 2022
@Gustl22 Gustl22 deleted the upgrade-dartdoc branch May 15, 2022 15:00
st-pasha pushed a commit to st-pasha/flame that referenced this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants