feat: add FutureOr support on SpriteButton #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see the point of this change, can you please elaborate? |
Whether it's a Future or not, it ends up being a Future<List>. It can also be passed directly when you need to load the image asynchronously to create a Sprite or a method return Future like Sprite.load. In addition, it will not affect the case of directly passing Sprite as a parameter |
|
Ah, now when I looked at the rest of the code it makes sense! |
spydon
requested review from
erickzanardo,
spydon,
luanpotter,
renancaraujo and
wolfenrain
spydon
approved these changes
May 20, 2022
erickzanardo
approved these changes
May 22, 2022
6 tasks
spydon
pushed a commit
that referenced
this pull request
May 31, 2022
…#1674) At first, In #1667, I was planning to change only SpriteWidget to be able to remove showing LoadingBuilder when non-future sprite was passed. But after some digging, I found that BaseFutureBuilder causes the loading because it only accepts Future as a parameter. And BaseFutureBuilder are the very base of all image-related widgets such as NineTileBoxWidget, SpriteAnimationWidget, ... etc. So the key point of this change should allow BaseFutureBuilder to FutureOr as a parameter and split the build function according to the parameter type. After #1645, the Default constructor of SpriteButton can pass Future but its constructor is not consistent with other image-related widgets. Plus, type of FutureOr<List<Sprite>> _buttonsFuture only compatible with Future<List<Sprite>> but not List<Sprite>. So I added secondary constructor SpriteButton.future that accepts only Future and Replaced the FutureOr<Sprite> to Sprite in the default constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can use Future as its argument