feat: Children as argument to FlameGame #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st-pasha
approved these changes
May 29, 2022
Updated instructions in the "Bare Flame game" tutorial to account for the current Flutter min version of 2.10.0.
wolfenrain
approved these changes
May 31, 2022
spydon
requested review from
wolfenrain,
erickzanardo,
luanpotter and
renancaraujo
wolfenrain
approved these changes
Jun 1, 2022
erickzanardo
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
This is a small, but an incredible improvement IMO, this will help bring Flame to a more declarative pattern. I wonder if we could create a game that doesn't even require the player to extend from FlameGame!
I think it would be nice to briefly mention this new attribute on the docs.
I do mention it in the docs. 🙂 |
erickzanardo
reviewed
Jun 1, 2022
st-pasha
pushed a commit
to st-pasha/flame
that referenced
this pull request
Jun 3, 2022
Since we have already added children as an argument to Component, this adds it to the FlameGame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we have already added
childrenas an argument toComponent, this adds it to theFlameGame.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Related Issues