Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flame_bloc] Expose bloc instance on FlamBlocListenable #1694

Closed
erickzanardo opened this issue Jun 3, 2022 · 0 comments · Fixed by #1732
Closed

[flame_bloc] Expose bloc instance on FlamBlocListenable #1694

erickzanardo opened this issue Jun 3, 2022 · 0 comments · Fixed by #1732
Labels
enhancement

Comments

@erickzanardo
Copy link
Member

Problem to solve

To have access to a bloc inside FlameBlocListenable one needs to also add FlameBlocReader on it. Which is a cumbersome API.

Proposal

FlameBlocListenable already holds the bloc instance in it as seen here.

We should simply provide a getter to it.

More information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adding bloc getter to FlameBlocListenable mixin AdrienDelgado/flame
1 participant
@erickzanardo