Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove nonVirtual method shouldRemove #1707

Merged
merged 2 commits into from
Jun 7, 2022
Merged

fix: Remove nonVirtual method shouldRemove #1707

merged 2 commits into from
Jun 7, 2022

Conversation

spydon
Copy link
Member

@spydon spydon commented Jun 7, 2022

Description

Some of these tests are a bit strange, but that's outside of the scope of this PR.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • No, this is not a breaking change.

Related Issues

luanpotter
luanpotter approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spydon spydon merged commit 1efd067 into main Jun 7, 2022
@spydon spydon deleted the spydon.remove-should-remove branch June 7, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luanpotter luanpotter luanpotter approved these changes

@st-pasha st-pasha st-pasha approved these changes

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spydon @luanpotter @st-pasha