fix: Fix flame package example app #1709
Conversation
| @@ -80,6 +67,7 @@ class Square extends PositionComponent with Tappable { | |||
| @override | |||
| bool onTapUp(TapUpInfo info) { | |||
| removeFromParent(); | |||
| info.handled = true; | |||
There was a problem hiding this comment.
because returning true no longer sets it automatically
There was a problem hiding this comment.
so the check to avoid adding a new square works
There was a problem hiding this comment.
otherwise it will remove and then re-add the square. that is doing nothing with extra steps
There was a problem hiding this comment.
I thought true meant handled
There was a problem hiding this comment.
true means continue to propagate, but it always ends up on the game it seems like? I wonder if that is a bug...
You can check info.continuePropagation on the game, but then it's cleaner to do lile you did before.
There was a problem hiding this comment.
Yeah, it must have always been like that, since that is the entry point, I'll merge this
| @@ -80,6 +67,7 @@ class Square extends PositionComponent with Tappable { | |||
| @override | |||
| bool onTapUp(TapUpInfo info) { | |||
| removeFromParent(); | |||
| info.handled = true; | |||
| return true; | |||
Description
Our main example for the flame package was no longer working due to some changes on the input system, namely the need to manually mark events as handled.
I also removed some pausing logic that I do not think belongs on the main example, that can be a separate topic on the dashbook example. This example should be simple and contain key learning topics.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change