Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Update flame_audio to AP 1.0.0 #1724

Merged
merged 11 commits into from
Jun 14, 2022
Merged

feat!: Update flame_audio to AP 1.0.0 #1724

merged 11 commits into from
Jun 14, 2022

Conversation

luanpotter
Copy link
Member

@luanpotter luanpotter commented Jun 12, 2022 •
edited
Loading

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Migration instructions

Basically follow AP's 1.0.0 migration guide. Flame Audio APIs were updated to match the new design philosophies.

@luanpotter luanpotter changed the title Luan.flame audio Update flame_audio to AP 1.0.0 Jun 12, 2022
@luanpotter luanpotter changed the title Update flame_audio to AP 1.0.0 feat!: Update flame_audio to AP 1.0.0 Jun 12, 2022
@luanpotter luanpotter changed the title feat!: Update flame_audio to AP 1.0.0 chore!: Update flame_audio to AP 1.0.0 Jun 12, 2022
@luanpotter luanpotter changed the title chore!: Update flame_audio to AP 1.0.0 feat!: Update flame_audio to AP 1.0.0 Jun 12, 2022
spydon
spydon approved these changes Jun 12, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some doc updates right?

@luanpotter
Copy link
Member Author

Possibly

@luanpotter luanpotter marked this pull request as ready for review June 12, 2022 15:11
@luanpotter luanpotter requested a review from a team June 12, 2022 15:11
spydon
spydon approved these changes Jun 12, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just some doc comments

doc/flame_audio/audio.md Outdated Show resolved Hide resolved
doc/flame_audio/audio.md Outdated Show resolved Hide resolved
doc/flame_audio/audio.md Outdated Show resolved Hide resolved
doc/flame_audio/audio_pool.md Outdated Show resolved Hide resolved
doc/flame_audio/audio_pool.md Outdated Show resolved Hide resolved
doc/flame_audio/audio_pool.md Outdated Show resolved Hide resolved
packages/flame_audio/example/lib/main.dart Show resolved Hide resolved
packages/flame_audio/lib/audio_pool.dart Outdated Show resolved Hide resolved
luanpotter and others added 2 commits June 12, 2022 11:44
@luanpotter @spydon
Apply suggestions from code review
115f26d 
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
@luanpotter @spydon
Update doc/flame_audio/audio.md
723c570 
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
@luanpotter luanpotter requested a review from spydon June 12, 2022 15:45
spydon
spydon approved these changes Jun 12, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@spydon
Copy link
Member

spydon commented Jun 12, 2022

Ooh, would actually be awesome with at short example in the examples directory too.

@spydon spydon requested a review from a team June 12, 2022 21:28
luanpotter
luanpotter commented Jun 13, 2022
View reviewed changes
doc/flame_audio/audio.md Outdated Show resolved Hide resolved
@luanpotter
Copy link
Member Author

Ooh, would actually be awesome with at short example in the examples directory too.

I already provide an example underr package/flame_audio/example.
Do you think we need to add one on the dashbook examples app too? If so should it be the same? Or something different?

@spydon
Copy link
Member

spydon commented Jun 13, 2022

I already provide an example underr package/flame_audio/example. Do you think we need to add one on the dashbook examples app too? If so should it be the same? Or something different?

The same one I think would be fine, I think our users more easily find the dashbook examples.

@luanpotter luanpotter merged commit d6bf920 into main Jun 14, 2022
@luanpotter luanpotter deleted the luan.flame-audio branch June 14, 2022 04:12
st-pasha pushed a commit to st-pasha/flame that referenced this pull request Jun 18, 2022
@luanpotter @st-pasha
feat!: Update flame_audio to AP 1.0.0 (flame-engine#1724)
7121b19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luanpotter @spydon @erickzanardo