Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing paint arguments on shapes #1727

Merged
merged 2 commits into from
Jun 14, 2022
Merged

fix: Add missing paint arguments on shapes #1727

merged 2 commits into from
Jun 14, 2022

Conversation

spydon
Copy link
Member

@spydon spydon commented Jun 13, 2022

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • [-] I have updated/added tests for ALL new/updated/fixed functionality.
  • [-] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@spydon spydon requested a review from a team June 13, 2022 20:53
@spydon spydon enabled auto-merge (squash) June 13, 2022 20:53
luanpotter
luanpotter approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spydon spydon merged commit e59f342 into main Jun 14, 2022
@spydon spydon deleted the spydon.add-shape-paints branch June 14, 2022 04:48
st-pasha pushed a commit to st-pasha/flame that referenced this pull request Jun 18, 2022
@spydon @st-pasha
fix: Add missing paint arguments on shapes (flame-engine#1727)
07ec8ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luanpotter luanpotter luanpotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spydon @luanpotter