Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tiled example size #1729

Merged
merged 4 commits into from
Jun 14, 2022
Merged

fix: tiled example size #1729

merged 4 commits into from
Jun 14, 2022

Conversation

ConcealGeek
Copy link
Contributor

@ConcealGeek ConcealGeek commented Jun 14, 2022 •
edited
Loading

Description

The tiled example lacks the size parameter on the spriteanimationcomponent component, so it cannot correctly display gold coins

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • No, this is not a breaking change.

Related Issues

luanpotter
luanpotter approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luanpotter luanpotter merged commit 8306fc1 into flame-engine:main Jun 14, 2022
st-pasha pushed a commit to st-pasha/flame that referenced this pull request Jun 18, 2022
@ConcealGeek @st-pasha
fix: tiled example size (flame-engine#1729)
cb9c4d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luanpotter luanpotter luanpotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ConcealGeek @luanpotter @GeekToolGroup