Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added size parameter for testGolden() #1780

Merged
merged 4 commits into from
Jul 3, 2022
Merged

feat: Added size parameter for testGolden() #1780

merged 4 commits into from
Jul 3, 2022

Conversation

st-pasha
Copy link
Contributor

@st-pasha st-pasha commented Jul 3, 2022

Description

Added size parameter to testGolden() function, allowing us to reduce the size of the game canvas used. The default size is 2400x1800, as given by the Flutter framework, seems like too much for most tests.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples.

Breaking Change

  • [-] Yes, this is a breaking change.
  • No, this is not a breaking change.

@st-pasha st-pasha mentioned this pull request Jul 3, 2022
Merged
6 tasks
@spydon spydon merged commit 8e41d83 into main Jul 3, 2022
@spydon spydon deleted the ps.golden-test-size branch July 3, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

@luanpotter luanpotter Awaiting requested review from luanpotter

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st-pasha @spydon