Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: EventComponentMixins missing @mustCallSuper added #2036

Merged
merged 1 commit into from
Oct 6, 2022
Merged

fix: EventComponentMixins missing @mustCallSuper added #2036

merged 1 commit into from
Oct 6, 2022

Conversation

ShwetaChauhan18
Copy link
Contributor

Description

  • 🐛 Event component_mixins missing @mustCallSuper added

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@shwetachauhan-simform
fix: Event mixins missing @mustCallSuper
f84593a 
   - 🐛 Event mixins missing `@mustCallSuper`
erickzanardo
erickzanardo approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@erickzanardo erickzanardo requested review from st-pasha and a team October 6, 2022 13:40
@spydon spydon merged commit c26d5da into flame-engine:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@erickzanardo erickzanardo erickzanardo approved these changes

@st-pasha st-pasha Awaiting requested review from st-pasha

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShwetaChauhan18 @spydon @erickzanardo @shwetachauhan-simform