Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DialogueRunner for jenny #2113

Merged
merged 95 commits into from
Nov 5, 2022
Merged

feat: DialogueRunner for jenny #2113

merged 95 commits into from
Nov 5, 2022

Conversation

st-pasha
Copy link
Contributor

@st-pasha st-pasha commented Oct 23, 2022 •
edited
Loading

Description

The DialogueRunner is the engine that actually runs the dialogue.

Note: documentation will be added in PR #2102.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • [-] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

@st-pasha
initial project files
7f9bc29
@st-pasha
Added ASCII table
480dce6
@st-pasha
Lexer wip
f233839
@st-pasha
Moved out Token class
bdb2cb7
@st-pasha
Improve Token class
d586c4e
@st-pasha
Clean up of the Lexer class
ffaf1e3
@st-pasha
rename into tokenize
a441b49
@st-pasha
better error messages
ed2701f
@st-pasha
dont abbreviate ascii character names
42e67ef
@st-pasha
added Token and ascii tests
2d2287b
@st-pasha
Token.operator==
24f23db
@st-pasha
added some tokenizer tests
219980c
@st-pasha
tests for modeNodeBody
862684d
@st-pasha
missing tests for Token
c3578ab
@st-pasha
unicode names parser for Token.character
e6afa75
@st-pasha
modeNodeBodyLine tests
d9d9839
@st-pasha
ModeText tests
67ff563
@st-pasha
ModeText tests
8aa7218
@st-pasha
expression tests
4a703a9
@st-pasha
better token names
941bdbc
@st-pasha
formatting
a2cfbbf
@st-pasha
more tests for unicode ids
5c312c2
@st-pasha
added remaining tests
a062eeb
@st-pasha
line tags and commands
26bbaf8
@st-pasha
format
9319026
@st-pasha
Merge branch 'main' into ps.flame-yarn-lexer
c317f86
@st-pasha
delete changelog
5166e29
@st-pasha
rename as -> asType
5111c15
@st-pasha
rename pos -> position
cbc3743
@st-pasha
renamed codeUnit -> currentCodeUnit
75425d4
spydon
spydon reviewed Oct 24, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Great dartdocs on the DialogueRunner.

packages/flame_yarn/README.md Outdated Show resolved Hide resolved
packages/flame_yarn/test/parse/tokenize_test.dart Outdated Show resolved Hide resolved
@spydon spydon requested a review from a team October 24, 2022 19:15
@st-pasha st-pasha mentioned this pull request Oct 31, 2022
Merged
4 tasks
@st-pasha st-pasha changed the title feat: DialogueRunner for flame_yarn feat: DialogueRunner for jenny Nov 3, 2022
@spydon spydon enabled auto-merge (squash) November 5, 2022 11:29
@spydon spydon merged commit 5ba6ff2 into main Nov 5, 2022
@spydon spydon deleted the ps.yarn-dialogue-runner branch November 5, 2022 11:38
@st-pasha st-pasha added the jenny Issues/PRs related to the Jenny package label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
jenny Issues/PRs related to the Jenny package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st-pasha @spydon