Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Export rive from flame_rive #2130

Merged
merged 4 commits into from
Oct 29, 2022
Merged

fix: Export rive from flame_rive #2130

merged 4 commits into from
Oct 29, 2022

Conversation

spydon
Copy link
Member

@spydon spydon commented Oct 29, 2022

Description

Just like we do for flame_forge2d, since most users will need the classes from rive too when using flame_rive.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@spydon spydon requested a review from a team October 29, 2022 09:23
@spydon spydon enabled auto-merge (squash) October 29, 2022 09:47
@spydon spydon merged commit d183332 into main Oct 29, 2022
@spydon spydon deleted the spydon/rive-to-be-exported branch October 29, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfenrain wolfenrain wolfenrain approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spydon @wolfenrain