Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for markup attributes #2183

Merged
merged 14 commits into from
Nov 24, 2022
Merged

feat: Added support for markup attributes #2183

merged 14 commits into from
Nov 24, 2022

Conversation

st-pasha
Copy link
Contributor

Description

Markup allows inserting additional information into the text, without affecting dialogue views who cannot handle that information. See https://docs.yarnspinner.dev/getting-started/writing-in-yarn/markup

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@spydon spydon merged commit f887545 into main Nov 24, 2022
@spydon spydon deleted the ps.jenny-markup branch November 24, 2022 07:14
@st-pasha st-pasha changed the title feat(jenny): Added support for markup attributes feat: Added support for markup attributes Nov 24, 2022
@st-pasha st-pasha added the jenny Issues/PRs related to the Jenny package label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenny Issues/PRs related to the Jenny package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants