Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove whitespace before a command in dialogue option #2187

Merged
merged 21 commits into from
Nov 24, 2022
Merged

Conversation

st-pasha
Copy link
Contributor

Description

Previously, a line such as -> Choice 1 <<if $condition>> would generate text "Choice 1 " (with an extra space at the end), this is now fixed.

Also added several tests from the Yarn integration testing suite.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • [-] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@st-pasha st-pasha added the jenny Issues/PRs related to the Jenny package label Nov 24, 2022
@spydon spydon enabled auto-merge (squash) November 24, 2022 20:09
@spydon spydon merged commit 00f0e33 into main Nov 24, 2022
@spydon spydon deleted the ps.jenny-tests branch November 24, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenny Issues/PRs related to the Jenny package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants