Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add onCancelled to ButtonComponent and HudButtonComponent #2193

Merged
merged 4 commits into from
Nov 27, 2022
Merged

feat: add onCancelled to ButtonComponent and HudButtonComponent #2193

merged 4 commits into from
Nov 27, 2022

Conversation

lukepighetti
Copy link
Contributor

@lukepighetti lukepighetti commented Nov 26, 2022 •
edited
Loading

Description

Adds onCancelled to ButtonComponent and HudButtonComponent

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

#2191 (comment)

@lukepighetti lukepighetti changed the title add onCancelled to ButtonComponent and HudButtonComponent feat: add onCancelled to ButtonComponent and HudButtonComponent Nov 26, 2022
spydon
spydon approved these changes Nov 27, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@spydon spydon requested a review from a team November 27, 2022 17:15
@spydon spydon enabled auto-merge (squash) November 27, 2022 17:57
@spydon spydon merged commit e7f0890 into flame-engine:main Nov 27, 2022
@spydon spydon mentioned this pull request Nov 27, 2022
Closed
@lukepighetti lukepighetti deleted the lukepighetti/ButtonComponent-onCancelled branch November 28, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukepighetti @spydon @erickzanardo