feat!: Adds new route methods pushReplacement, pushReplacementNamed, and pushReplacementOverlay
#2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
…/flame into Adds-route-methods
st-pasha
reviewed
Jan 6, 2023
munsterlander
changed the title
pushNamedReplacement, pushReplacement, and pushReplacementOverlaypushNamedReplacement, pushReplacement, and pushReplacementOverlay
st-pasha
reviewed
Jan 10, 2023
spydon
approved these changes
Jan 10, 2023
st-pasha
approved these changes
Jan 10, 2023
st-pasha
changed the title
pushNamedReplacement, pushReplacement, and pushReplacementOverlaypushReplacement, pushReplacementNamed, and pushReplacementOverlay
…/flame into Adds-route-methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the aforementioned methods to the router component so a user can replace the current route / overlay with something else without having to call
popthenpush. Additionally, it corrects an error in the router documents aspopPage()does not exist as the call is justpop().Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes: #2177