fix: Incorrect JoystickComponent position in landscape mode #2387 #2389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When in landscape mode, a Component will need to be repositioned based on the new canvas
dimensions. If a Component has not reached the mounted state when
HudMarginComponent.onGameResize is called, then _updateMargins will not be called, and
the position will not be updated.
This PR removes the check that the Component has reached the mounted state in
HudMarginComponent.onGameResize so that _updateMargins will always be called.
Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues