fix: Auto-resize SpriteComponent on sprite change
#2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzanardo
approved these changes
Mar 26, 2023
5 tasks
spydon
pushed a commit
that referenced
this pull request
Apr 1, 2023
…ationGroupComponent` (#2453) This PR extends autoResize to SpriteAnimationComponent and SpriteAnimationGroupComponent similar to what was done in #2430 and #2442. Additionally, this PR also adds playing property to SpriteAnimationGroupComponent. If it is desired to make this appear as a separate entry in the changlog, I can move this change to a separate PR as it is completely unrelated to the auto-resize changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an
autoResizeparameter toSpriteComponentusing which users will be able to control if the component should auto-resize on sprite change to match the sprite'ssrcSize. Some important design decisions aboutautoResize:It is mutually exclusive with
sizewhile construction: This means, ifsizeis non-null while construction ofSpriteComponent,autoResizecannot be true. This allows use-cases where one might want to render a sprite at a different size than its original size. If an user is setting the size explicitly, we can leave it up to them to handle resizing in such cases.It is optional: If an user does not set this parameter while construction, it will be auto-populated depending upon if a
sizeis provided or not.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #2419