Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update AudioPlayers to ^4.0.0 #2482

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

spydon
Copy link
Member

@spydon spydon commented Apr 11, 2023

Description

This updates flame_audio to use the recently released audioplayers 4.0.0

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.

Migration instructions

AudioPool has moved to AudioPlayers, but we still export it from flame_audio, so the only thing you have to do if you import AudioPool directly is to change the import to:
import 'package:flame_audio/flame_audio.dart';

Related Issues

Migration instructions:
AudioPool has moved to AudioPlayers, but we still export it from
flame_audio, so the only thing you have to do if you import AudioPool
directly is to change the import to:
import 'package:flame_audio/flame_audio.dart';
@spydon spydon requested a review from a team April 11, 2023 15:33
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@spydon spydon merged commit 4737208 into main Apr 11, 2023
@spydon spydon deleted the spydon/update-flame_audio branch April 11, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants