Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make atlas status to be more readable #2502

Merged
merged 6 commits into from
Apr 15, 2023

Conversation

Hwan-seok
Copy link
Contributor

Description

At present, indicating the status of the flipped atlas is a bit hard to follow because there are two booleans to decide the status. Actually, they can be represented as a 3-step enum.

This replaces two booleans that indicate the status of the flipped atlas with 3-step enum.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

packages/flame/lib/src/sprite_batch.dart Outdated Show resolved Hide resolved
packages/flame/lib/src/sprite_batch.dart Outdated Show resolved Hide resolved
@spydon spydon enabled auto-merge (squash) April 15, 2023 22:11
@spydon spydon merged commit 643793d into flame-engine:main Apr 15, 2023
@Hwan-seok Hwan-seok deleted the hwanseok.refact-batch-flip-status branch April 16, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants