Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Enable new DCM rule: avoid-cascade-after-if-null #2676

Merged
merged 4 commits into from
Aug 26, 2023
Merged

refactor: Enable new DCM rule: avoid-cascade-after-if-null #2676

merged 4 commits into from
Aug 26, 2023

Conversation

luanpotter
Copy link
Member

@luanpotter luanpotter commented Aug 25, 2023 •
edited
Loading

Description

Enable new DCM rule: avoid-cascade-after-if-null
Reference: https://dcm.dev/docs/rules/common/avoid-cascade-after-if-null/

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter luanpotter force-pushed the luan.dcm.1 branch 3 times, most recently from 1f708dd to a83b8b2 Compare August 25, 2023 04:25
@luanpotter luanpotter changed the title refactor: Enable a batch of DCM rules (1) refactor: Enable new DCM rule: avoid-cascade-after-if-null Aug 25, 2023
@luanpotter luanpotter marked this pull request as ready for review August 25, 2023 16:24
@spydon spydon enabled auto-merge (squash) August 26, 2023 10:24
@spydon spydon merged commit 158fc34 into main Aug 26, 2023
7 checks passed
@spydon spydon deleted the luan.dcm.1 branch August 26, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luanpotter @spydon