Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Update should be called before render in first tick #2714

Merged
merged 7 commits into from
Sep 14, 2023

Conversation

spydon
Copy link
Member

@spydon spydon commented Sep 8, 2023

Description

Previously render was called before the first update was called, which should be considered as a bug.

Checklist

  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.

Migration instructions

In some very rare cases this could be a breaking change for your game, since the logic can vary a lot between games there is no clear migration instruction, except for that you should expect an update(0) to be called directly after onMount and before render.

Related issues

#2707 #2674

@spydon spydon merged commit 51932c0 into main Sep 14, 2023
7 checks passed
@spydon spydon deleted the spydon/update-before-render branch September 14, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants