Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding scale parameter to RectangleComponent constructors #2730

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

erickzanardo
Copy link
Member

Description

While working with RectangleComponent I noticed that it doesn't expose its super scale parameter, this PR changes that.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@erickzanardo erickzanardo changed the title feat: adding scale parameter to RectangleComponent constructors. feat: Adding scale parameter to RectangleComponent constructors. Sep 11, 2023
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just some nitpicks.
It seems like it is missing for the CircleComponent too.

packages/flame/lib/src/geometry/rectangle_component.dart Outdated Show resolved Hide resolved
packages/flame/lib/src/geometry/rectangle_component.dart Outdated Show resolved Hide resolved
packages/flame/lib/src/geometry/rectangle_component.dart Outdated Show resolved Hide resolved
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
@spydon spydon changed the title feat: Adding scale parameter to RectangleComponent constructors. feat: Adding scale parameter to RectangleComponent constructors Sep 12, 2023
@spydon
Copy link
Member

spydon commented Sep 12, 2023

@erickzanardo fixed up those small nits so that you don't have to, hope your don't mind 😅

@spydon spydon changed the title feat: Adding scale parameter to RectangleComponent constructors fix: Adding scale parameter to RectangleComponent constructors Sep 12, 2023
@spydon spydon enabled auto-merge (squash) September 12, 2023 21:15
@spydon spydon merged commit 173908d into main Sep 12, 2023
8 checks passed
@spydon spydon deleted the erickzanardo-patch-1 branch September 12, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants