Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flame_audio): Adding an easy way of updating the prefix from FlameAudio #2751

Merged
merged 4 commits into from
Sep 19, 2023
Merged

feat(flame_audio): Adding an easy way of updating the prefix from FlameAudio #2751

merged 4 commits into from
Sep 19, 2023

Conversation

erickzanardo
Copy link
Member

Description

It was already possible to update the prefixes of FlameAudio assets, but it required a certain understanding of FlameAudio and Audioplayers.

This PR adds a simple helper method that makes it easier to change without requiring much context of the internals of the package.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@erickzanardo erickzanardo requested a review from a team September 19, 2023 13:57
spydon
spydon approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, except the little nit (which the analyzer also complains about).

packages/flame_audio/lib/flame_audio.dart Outdated Show resolved Hide resolved
@erickzanardo erickzanardo enabled auto-merge (squash) September 19, 2023 16:01
@erickzanardo erickzanardo merged commit d2c9dce into main Sep 19, 2023
7 checks passed
@erickzanardo erickzanardo deleted the feat/flame_audio_prefix_change branch September 19, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erickzanardo @spydon