fix!: Add DisplacementEvent to fix delta coordinate transformations for drag events #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanpotter
force-pushed
the
luan.spydon.fix-delta
branch
3 times, most recently
from
f6d2ba1
to
2b8d1bb
Compare
luanpotter
force-pushed
the
luan.spydon.fix-delta
branch
from
2b8d1bb
to
af9a2a6
Compare
luanpotter
commented
Nov 26, 2023
| ); | ||
|
|
||
| final int pointerId; | ||
| final Duration timestamp; | ||
| final Vector2 delta; | ||
|
|
||
| static final _nanPoint = Vector2.all(double.nan); |
spydon
reviewed
Nov 27, 2023
spydon
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds
DisplacementEventto fix delta coordinate transformations for drag events, to be used instead ofPositionEvent.Drag Events now expose the start and end position, as well as the delta, correctly transformed by the camera and zoom.
This also ensures that drag events, once starts, do not get lost if the drag update leaves the component bounds.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Migration instructions
DragUpdateEventevents, thedevicePosition,canvasPosition,localPosition, anddeltaare deprecated as they are unclear.xStartPositionto get the position at the start of the drag event ("from")xEndPositionto get the position at the end of the drag event ("to")localDelta. it now already considers the camera zoom. no need to manually account for thatRelated Issues
This fixes #2843