Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow setting bounds while BoundedPositionBehavior's target is null #2926

Merged
merged 2 commits into from
Dec 17, 2023

Conversation

ufrshubham
Copy link
Member

@ufrshubham ufrshubham commented Dec 16, 2023

Description

The bounds setter of BoundedPositionBehavior tries to update the target's position when bounds are updated. But it wasn't checking if the target is null. This was causing null exceptions while updating bounds of an unmounted BoundedPositionBehavior with null target (as seen in this failing test case). This PR fixes that by checking if the target is null before updating the position.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #2655

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@spydon spydon merged commit bab9be6 into main Dec 17, 2023
10 checks passed
@spydon spydon deleted the devkage/bounded-position-behaviour-null-target branch December 17, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BoundedPositionBehavior fails with target == null
2 participants