fix: Misalignment of the hittest area of PolygonHitbox #2930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
reviewed
Dec 17, 2023
| import 'package:test/test.dart'; | ||
|
|
||
| void main() { | ||
| group('PolygonComponent', () { |
There was a problem hiding this comment.
Could you move this to shape_component_test where the other tests for this are?
There are some inconsistencies of which directories the tests live currently so it can be quite hard to find the correct place. 😅
|
If you run |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When performing a pointer hit test using PolygonHitbox, there may be a discrepancy between the expected range and the range in which the hit test succeeds. If the polygon shape has an offset at the top left, the hit test will behave as if there is no offset.
Investigation revealed that the cause was in the calculation of containsLocalPoint() in the PolygonComponent. The unnecessary offset calculation was removed, and the hit test is now performed in the expected range.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #2758