Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The visibleGameSize should be based on viewport.virtualSize #2945

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

spydon
Copy link
Member

@spydon spydon commented Dec 21, 2023

Description

The visibleGameSize should be based on the virtual size of the viewport, otherwise it won't work for FixedResolutionViewport for example.
We noticed this when using the ScreenHitbox in a world that was looked upon by a camera with a FixedResolutionViewport.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spydon spydon enabled auto-merge (squash) December 21, 2023 16:41
@spydon spydon merged commit bd130b7 into main Dec 21, 2023
8 checks passed
@spydon spydon deleted the fix/visible-game-size branch December 21, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants