Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PolygonComponent.containsLocalPoint to use anchor #2953

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

spydon
Copy link
Member

@spydon spydon commented Dec 27, 2023

Description

Apparently PolygonComponent.containsLocalPoint has to take the anchor into consideration, I have no idea how nobody noticed this before...

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

@spydon spydon changed the title fix: PolygonComponent.containsLocalPoint to use anchor fix: PolygonComponent.containsLocalPoint to use anchor Dec 27, 2023
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spydon spydon enabled auto-merge (squash) January 4, 2024 16:53
@spydon spydon merged commit 7969321 into main Jan 4, 2024
8 checks passed
@spydon spydon deleted the fix/polygon-component-hittest branch January 4, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants