Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Notifier for changing current sprite/animation in group components #2956

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

spydon
Copy link
Member

@spydon spydon commented Jan 4, 2024

Description

With these new notifiers you can get notified when the current animation or sprite changes in the group components.
The value notifier is not initialized unless the user tries to use it, so it doesn't carry any extra weight on the components.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM bar the nice github analyzer notes

Also wondering whether we should have a standard/philosophy on where to add these listeners or not. theoretically we could add them on every single field, but I suspect we want to strike some sort of balance.

@spydon
Copy link
Member Author

spydon commented Jan 4, 2024

LGTM bar the nice github analyzer notes

Also wondering whether we should have a standard/philosophy on where to add these listeners or not. theoretically we could add them on every single field, but I suspect we want to strike some sort of balance.

Yeah, I think we should apply YAGNI, and now someone asked for it on Discord and I estimated this to be a legit usecase.

@spydon spydon enabled auto-merge (squash) January 4, 2024 16:48
@spydon spydon merged commit 75cf239 into main Jan 4, 2024
8 checks passed
@spydon spydon deleted the feat/current-notifiers-groups branch January 4, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants