fix: Size for SpriteComponent.fromImage
should be nullable
#3054
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I received an assertion error after I set
autoResize
to true when I am usingSpriteComponent.fromImage
component. It's kinda weird for me that the message tells me "If size is set, autoResize should be false or size should be null when autoResize is true.'', but the thing is I never set the size for that image yet. Then, I check the code and I found out that the size will never be null anyway, so theautoresize
should always be false.In this PR, I just remove all the fallback value for
size
, so it would not give an assertion error whensize
is not being set yet while theautoresize
is true.Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?