fix: Clamp opacity set by the ColorEffect to 1.0
#3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added unit test to attempt to set opacity greater than 1
1 task
billy1380
changed the title
spydon
changed the title
spydon
changed the title
ColorEffect to 1.0
spydon
approved these changes
Mar 6, 2024
All done now 🙏 |
spydon
reviewed
Mar 6, 2024
| @@ -46,7 +46,7 @@ class ColorEffect extends ComponentEffect<HasPaint> { | |||
| // Currently there is a bug when opacity is 0 in the color filter. | |||
| // "Expected a value of type 'SkDeletable', but got one of type 'Null'" | |||
| // https://github.com/flutter/flutter/issues/89433 | |||
| max(_tween.transform(progress), 1 / 255), | |||
| min(max(_tween.transform(progress), 1 / 255), 1), | |||
There was a problem hiding this comment.
Suggested change
| min(max(_tween.transform(progress), 1 / 255), 1), | |
| min(max(_tween.transform(progress), 0), 1), |
The bug mentioned above is fixed, maybe we could bundle this into the PR too? And remove the comment above.
There was a problem hiding this comment.
I have updated the pr and the description.
- since flutter/flutter#89433 has now been fixed
spydon
approved these changes
Mar 6, 2024
auto-merge was automatically disabled
March 6, 2024 13:39
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clamp opacity set by the ColorEffect to 1.0; this was causing an issue when the tween returned values greater than 1.
The test shows that when dt is greater than 0.5 and less than 0.75 for a period of 1 the tween returns approx 1.2 which causes Color to throw an exception.
This has now been fixed.
Since flutter/flutter#89433 has also now been fixed, I have changed the min opacity to 0.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues