feat: Add onComplete callback and a newLineNotifier to TextBoxComponent and ScrollTextBoxComponent #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
reviewed
Mar 27, 2024
packages/flame/lib/src/components/scroll_text_box_component.dart
Outdated
Show resolved
Hide resolved
|
@spydon |
You can create it in a new file with the name of the component, next to this one: Since your PR only covers |
spydon
reviewed
Mar 28, 2024
ScrollTextBoxComponent makes use of newLinePositionNotifier change/add tests change docs
Correct test variable declaration
spydon
reviewed
Mar 28, 2024
Comment on lines
19
to
21
| late final ValueNotifier<int> _newLineNotifier; | ||
|
|
||
| ValueNotifier<int> get newLineNotifier => _newLineNotifier; |
There was a problem hiding this comment.
Suggested change
| late final ValueNotifier<int> _newLineNotifier; | |
| ValueNotifier<int> get newLineNotifier => _newLineNotifier; | |
| late final ValueNotifier<int> newLineNotifier; |
It should be fine to have just this one
There was a problem hiding this comment.
Thanks, you're right :)
spydon
approved these changes
Mar 28, 2024
KurtLa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides an
onCompletecallback to trigger actions after text is fully displayed. Furthermore adds a NotifiernewLineNotifierfor notifications when a new line starts.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Fixes #3088