Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ability to convert between TextPaint and InlineTextStyle #3128

Merged
merged 1 commit into from
Apr 18, 2024
Merged

feat: Add ability to convert between TextPaint and InlineTextStyle #3128

merged 1 commit into from
Apr 18, 2024

Conversation

luanpotter
Copy link
Member

Description

Add ability to convert between TextPaint and InlineTextStyle.

The opposite is already possible with asTextRenderer, which this exposes.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter luanpotter marked this pull request as ready for review April 18, 2024 03:18
spydon
spydon approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@spydon spydon merged commit 6b63a57 into main Apr 18, 2024
8 checks passed
@spydon spydon deleted the luan.convert-text-paint-to-style branch April 18, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luanpotter @spydon