Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support inline code blocks on markdown rich text #3186

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

luanpotter
Copy link
Member

Description

Support inline code blocks on markdown rich text.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter luanpotter marked this pull request as ready for review June 6, 2024 12:31
@luanpotter luanpotter requested a review from spydon June 6, 2024 12:32
import 'package:flame/src/text/nodes/inline_text_node.dart';
import 'package:flame/text.dart';

class CodeTextNode extends InlineTextNode {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have dartdocs on it, do the other ones not have that either?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they don't. it's not really a class end users should be using. but I can add docs to all of them on a followup

@luanpotter luanpotter merged commit 67e069c into main Jun 6, 2024
8 checks passed
@luanpotter luanpotter deleted the luan.code branch June 6, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants