Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a getter for images cache keys #3324

Merged
merged 3 commits into from
Sep 30, 2024
Merged

feat: Add a getter for images cache keys #3324

merged 3 commits into from
Sep 30, 2024

Conversation

g0rdan
Copy link
Contributor

@g0rdan g0rdan commented Sep 30, 2024 •
edited
Loading

Description

Adds a keys getter in Images for retrieving all cache keys

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

#3237

@g0rdan g0rdan changed the title feat: add a getter for images cache keys feat: Add a getter for images cache keys Sep 30, 2024
erickzanardo
erickzanardo approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erickzanardo erickzanardo merged commit 7746f2f into flame-engine:main Sep 30, 2024
8 of 13 checks passed
@spydon spydon mentioned this pull request Oct 3, 2024
Closed
1 task
luanpotter pushed a commit that referenced this pull request Oct 15, 2024
@g0rdan @luanpotter
feat: Add a getter for images cache keys (#3324)
c8cddc6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g0rdan @erickzanardo