Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix SpriteBatch to comply with new drawAtlas requirement #3338

Merged
merged 11 commits into from
Oct 13, 2024

Conversation

luanpotter
Copy link
Member

@luanpotter luanpotter commented Oct 13, 2024

Description

Fix SpriteBatch to comply with new drawAtlas requirement

Fixes: #3331

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@@ -20,6 +20,11 @@ class SpriteBatchLoadExample extends FlameGame {

class MySpriteBatchComponent extends SpriteBatchComponent
with HasGameReference<SpriteBatchLoadExample> {
MySpriteBatchComponent()
: super(
blendMode: BlendMode.srcOver,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blend mode is now mandatory when using colors

@luanpotter luanpotter marked this pull request as ready for review October 13, 2024 16:03
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@luanpotter luanpotter merged commit a17fe4c into main Oct 13, 2024
8 checks passed
@luanpotter luanpotter deleted the luan.fix-batch branch October 13, 2024 16:09
luanpotter added a commit that referenced this pull request Oct 15, 2024
Fix SpriteBatch to comply with new drawAtlas requirement

Fixes: #3331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpriteBatch Examples throw errors and show black screens
2 participants