Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box Decoration for RectangleComponent #3374

Open
1 task done
stuartrapop opened this issue Nov 24, 2024 · 4 comments
Open
1 task done

Box Decoration for RectangleComponent #3374

stuartrapop opened this issue Nov 24, 2024 · 4 comments

Comments

@stuartrapop
Copy link

Problem to solve

The ability to style a rectangular position component with radius for border, border radius, border color, background color, border shadow (blur, color and offset), etc. and maybe hover over color.

I think this would be very useful for a lot of people, although this feature is definitely not urgent as the desired result can already be achieved (albeit with a bit of redundant code).

Proposal

Maybe a mixin on PositionComponent could make sense ?

More information

https://discord.com/channels/509714518008528896/1309774265930879006/1309774265930879006

Other

  • Are you interested in working on a PR for this?
@spydon
Copy link
Member

spydon commented Nov 25, 2024

Since PositionComponents most of the time aren't rectangular in how they are drawn on the canvas it might be a bit confusing to have this feature connected to the PositionComponent, a better candidate would be the RectangleComponent.

@stuartrapop
Copy link
Author

Since PositionComponents most of the time aren't rectangular in how they are drawn on the canvas it might be a bit confusing to have this feature connected to the PositionComponent, a better candidate would be the RectangleComponent.

Makes sense !

@ufrshubham ufrshubham changed the title Position Component with Box Decoration Box Decoration for RectangleComponent Dec 13, 2024
@spydon
Copy link
Member

spydon commented Dec 13, 2024

Do you want to work on this @stuartrapop? :)

@stuartrapop
Copy link
Author

Do you want to work on this @stuartrapop? :)

Yes, may I message you in mp for some guidance? I am eager to do this but started and quickly got stuck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants