Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rounded corners for screenshots #1156

Open
alperyilmaz opened this issue Nov 16, 2020 · 6 comments
Open

rounded corners for screenshots #1156

alperyilmaz opened this issue Nov 16, 2020 · 6 comments
Labels
Enhancement Feature requests and code enhancements Needs Decision This is something that should be discussed by community Plugin Issues related to plugins and API system

Comments

@alperyilmaz
Copy link

Is your feature request related to a problem? No

Hi. Is it possible to save the image with rounded corners? Maybe it can be added as a CLI option or maybe as an icon in the gui..
This is not a must have option but (I think) it's easy to implement and aestheticly pleasing..

@borgmanJeremy
Copy link
Contributor

How should we determine the radius of the rounded edge?

@borgmanJeremy borgmanJeremy added Enhancement Feature requests and code enhancements Needs Decision This is something that should be discussed by community labels Nov 18, 2020
@alperyilmaz
Copy link
Author

based on imagemagick code below, a set value can be used (such as 15). Or, it can be proportional to image size.
Also, for corners to be noticeable, alpha channel should be added to the image

convert $filename \( +clone -alpha extract \
   \( -size 15x15 xc:black -draw 'fill white circle 15,15 15,0' -write mpr:arc +delete \) \
   \( mpr:arc \) -gravity northwest -composite \
   \( mpr:arc -flip \) -gravity southwest -composite \
   \( mpr:arc -flop \) -gravity northeast -composite \
   \( mpr:arc -rotate 180 \) -gravity southeast -composite \) \
   -alpha off -compose CopyOpacity -composite

@borgmanJeremy
Copy link
Contributor

My question is more related to what is the best way in the GUI to let the user set the size of the radius. I think we should just follow the global thickness for now. @mmahmoudian thoughts?

@alperyilmaz
Copy link
Author

sorry, I completely misunderstand the intent. Maybe ctrl (or shift) mouse wheel can be used to determine roundedness thickness..

@mmahmoudian
Copy link
Member

mmahmoudian commented Nov 23, 2020

Interesting concept. Assuming that a user will not change this setting as frequent as thickness of tools, it might make more sense to have an option for it in General tab of the config UI (and a section in the config file corresponding to this) that gets the radius as an integer in pixels.

On general note, I personally don't find this feature useful, but I don't see it far off the general context of Flameshot either. Of course, one way to look at it is to implement a feature in Flameshot CLI that outputs the image to the stdout so that users can pipe it into any CLI pipeline.

@fdmarcin
Copy link

fdmarcin commented Dec 1, 2021

I'd like to have this option as well.

It could be configured in UI either as a slider or with a numerical value.

@mmahmoudian mmahmoudian added the Plugin Issues related to plugins and API system label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and code enhancements Needs Decision This is something that should be discussed by community Plugin Issues related to plugins and API system
Projects
None yet
Development

No branches or pull requests

4 participants