MacOS White Trayicon

[kholisrag]

Is your feature request related to a problem?

Can we have MacOS White Tray Icon?

its not good enough for my eye 😄

any simple way to make this possible?

[mmahmoudian]

I think almost most applications in MacOS use monochrome icons. I haven't worked with MacOS for some years now, but that's what I remember. Considering that we already have monochrome icons, it in theory should be easy to either change it or, similar to what bartender app does, let the user to decide which tray icon they want to use:

[borgmanJeremy]

@mmahmoudian we actually dont directly have a monochrome icon. Other people have themed the icon here for example. Then on linux Qt picks up that themed icon first.

On Mac the icon is actually compiled into the binary we would need to copy the svg from that git repo into our source tree and build the Mac version against it.

If we do that we need to modify the svg to include its license (GPLv3) and point back to the original author.

[mmahmoudian]

@borgmanJeremy interesting! I didn't know this. But about adding the SVG, we have the actual Flameshot icon. I think we can put together a monochrome stroke only version. This way it would be our own svg and we can license it to our project's preference.

[borgmanJeremy]

Yeah I'm not worried about the licensing, just want to make sure we credit properly. But yeah by all means if someone wants to make a new one that's fine with me.

[Faetu]

Hi @mmahmoudian

What ending has a monochrome icon?
And what is the size?

best regards

[mmahmoudian]

@Faetu If by ending you mean file extension or file format, would be nice to have SVG file. You can use the content of the following folder:
https://github.com/flameshot-org/flameshot/tree/master/data/img/app

Are you planning to make monochrome icon for Flameshot?

[Faetu]

Hi @mmahmoudian

Yes! Because it is easy for me. I done this for my linux tray icons.

Here you see flameshot and albert icon.
As you see, I made the individual flames in diferent transparency.

It will be done by tonight.

best regards

[Faetu]

Hi @mmahmoudian

Its done!

I made three types. One normal, without gaps between the flames.
A second with small gaps and a third with lager gaps between the flames.
All three in .png and .svg format.
flameshot.tray.zip

Now, how to continue to make this public and downloadable for everyone?
Do we need to make a pull-request?

best regards

[mmahmoudian]

@borgmanJeremy @veracioux what do you think is the best approach? Would it be good if @Faetu create a PR with these new icons in the same folder as the other icons:

https://github.com/flameshot-org/flameshot/tree/master/data/img/app

[veracioux]

I think it's better that one of the developers creates the PR, because the code needs to be changed as well. Of course ensuring proper credit to @Faetu. I could do it, but I don't have a Mac VM set up (yet), so I think it's better that someone else do it.

[borgmanJeremy]

Ok cool I'll do it.

[borgmanJeremy]

I think maybe we should take this opportunity to add a config option to switch between color and monochrome icons? Im certain someone on windows will ask for the same thing.

The alternative to is to simply package the monochrome icon on Mac when we build the .dmg.

[veracioux]

@borgmanJeremy We are adding too many config options 😄.

[borgmanJeremy]

I think the issue isn't the number of options, but how they are organized in the config screen.

[mmahmoudian]

As long as customisability doesn't affect the performance I personally don't see any issues in that. In contrary I think it would make it much easier for people to adopt it to their workflow.

[borgmanJeremy]

Okay so adding this as a run time configuration turned out to be pretty complicated to support across all the different DE's and operating systems. Not impossible, but as a first step I made it a build time option.

Feel free to test in on #2071 but it seems to work for me

[makew0rld]

How can I use the white tray icon on Linux XFCE? Right now it is the black version which is near impossible to see.

[borgmanJeremy]

Can you please open a separate issue for that? Icons in Linux are managed totally different and I don't want to clog this issue with that discussion. As a quick answer if you google XFCE change icon theme you will find it. But feel free to open something on the GitHub discussions if you need help.

[makew0rld]

My bad. I've created issue #2083.

[borgmanJeremy]

Merged new icon on Macos

[ww7]

Bug with multiple monitors setup, icon flattened on non active screen
#2071 (comment)