Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing numeric size issues #2265

Closed
Idomo opened this issue Jan 15, 2022 · 6 comments · Fixed by #2386
Closed

Typing numeric size issues #2265

Idomo opened this issue Jan 15, 2022 · 6 comments · Fixed by #2386
Labels
Bug It's a bug
Milestone

Comments

@Idomo
Copy link

Idomo commented Jan 15, 2022

Flameshot Version

Flameshot v11.0.0 (ad1bf28)

Installation Type

Using the ready-made package from Github Releases

Operating System type and version

macOS 12.1

Description

First of all, thanks for this great upgrade!
I've noticed 2 issues with the new feature Thickness of tools can now be set with the keyboard. Simply type a numerical value like "15" and you will see the indicator in the upper left.:

  1. It doesn't recognizing when pressing numbers on the numpad on the right side of the keyboard.
  2. When you're focusing on some text layer and typing a number that is smaller than the current size of the text, the old sized text stay on the screen (see screenshot).

Steps to reproduce

  1. Start the GUI
  2. Select area
  3. Type text
  4. Focus on the text
  5. Type size (e.g. 50)
  6. Type smaller size (e.g. 20)

Screenshots or screen recordings

image

System Information

I'm using an external monitor.

@Idomo Idomo added the Unconfirmed Bug The bug is not confirmed by anyone else. label Jan 15, 2022
@borgmanJeremy borgmanJeremy added Bug It's a bug and removed Unconfirmed Bug The bug is not confirmed by anyone else. labels Jan 16, 2022
@borgmanJeremy
Copy link
Contributor

Thanks! I replicated this on linux too so its not platform specific. We often have a point release to fix minor issues after a major release and this can get resolved there most likely.

@borgmanJeremy
Copy link
Contributor

If possible can you test #2386 ?

@Idomo
Copy link
Author

Idomo commented Feb 7, 2022

@borgmanJeremy I'm not sure how to download it, may you attach a dmg?

@mmahmoudian
Copy link
Member

mmahmoudian commented Feb 7, 2022

@Idomo Thank you for trying this and helping us resolving the issue. The following is the step-by-step instruction on how to get the artifact which is a ZIP file containing the .dmg file:

image

image

image

image

@Idomo
Copy link
Author

Idomo commented Feb 7, 2022

Thanks @mmahmoudian, it seems to be fixed with this commit.
I have another question that I'm not sure if thats a bug or not; Does double click on the selected area should automatically upload to imgur and copy the link?

@borgmanJeremy
Copy link
Contributor

I have another question that I'm not sure if thats a bug or not; Does double click on the selected area should automatically upload to imgur and copy the link?

No it should copy the image to clipboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug It's a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants