Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the preset color #2347

Closed
mmahmoudian opened this issue Jan 30, 2022 · 8 comments · Fixed by #2403
Closed

Change the preset color #2347

mmahmoudian opened this issue Jan 30, 2022 · 8 comments · Fixed by #2403
Assignees
Labels
Enhancement Feature requests and code enhancements

Comments

@mmahmoudian
Copy link
Member

mmahmoudian commented Jan 30, 2022

Feature Description

At the moment the hexadecimal number of the colors cannot be modified and instead the user have to add a new color and delete the one they don't like. It would be nice to be able to modify them on the spot.

Also would be nice to be able to re-arrange the colors in GUI

image

@mmahmoudian mmahmoudian added the Enhancement Feature requests and code enhancements label Jan 30, 2022
@deo002
Copy link
Contributor

deo002 commented Jan 31, 2022

@mmahmoudian How about removing the spinbox altogether? Users can select a preset by clicking it. In the spinbox's place, we can add 2 arrow buttons for reordering.

@mmahmoudian
Copy link
Member Author

mmahmoudian commented Jan 31, 2022

I don't know which one of the two circles are you referring to as "spinbox", but I assume it is the lower one. For the sake of this comment and until you correct me I'm going to call the top one "colorwheel" and the lower one "spinbox".

I believe the most intuitive UI would be that the spinbox goes in the center of the colorwheel and spinbox is only shown when one of the circles in the colorwheel is selected. And for reordering, I think dragging the circles in the preset colors is the intuitive way. In general something similar to what @veracioux proposed before

image

All these said, I don't know how easy or hard it is to implement these, plus this is just my personal opinion and other should also express their opinions.

But for the time being we need a method to modify the color in an existing preset color circle.

@deo002
Copy link
Contributor

deo002 commented Jan 31, 2022

I don't know which one of the two circles are you referring to as "spinbox"


The widget used for selecting colors.

@deo002
Copy link
Contributor

deo002 commented Jan 31, 2022

And for reordering, I think dragging the circles in the preset colors is the intuitive way.

I like this idea though. Better than the 2 arrow one.

@mmahmoudian
Copy link
Member Author

The widget used for selecting colors.

Imho this is very unintuitive. As a user I expected to be able to edit the text of that box you showed to change the hex of the selected color. I think the circles should be clickable and selectable (instead of selecting through the box you showed) and then instead of this box there should be a an input field to modify the hex of the selected circle.

@deo002
Copy link
Contributor

deo002 commented Feb 3, 2022

I think the circles should be clickable and selectable (instead of selecting through the box you showed) and then instead of this box there should be a an input field to modify the hex of the selected circle.

Sounds good! I would like to work on it.

@mmahmoudian
Copy link
Member Author

@deo002 let's first hear the opinion of other devs before diving into the code.

@borgmanJeremy @veracioux what do you think? Any feedbacks on the thread above?

@borgmanJeremy
Copy link
Contributor

I think what was discussed here sounds good to me. Dragging the circles seems like it might be complicated but it seems like the most intuitive way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and code enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants