Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned Image can't be closed anymore #2673

Closed
xstable opened this issue Jun 16, 2022 · 8 comments
Closed

Pinned Image can't be closed anymore #2673

xstable opened this issue Jun 16, 2022 · 8 comments
Labels
Unconfirmed Bug The bug is not confirmed by anyone else. Waiting For Info Addressing the issue or merging the PR is halted and we are waiting for more info to be provided.

Comments

@xstable
Copy link

xstable commented Jun 16, 2022

Flameshot Version

Flameshot v12.0.0 (b036e53)
Compiled with Qt 5.15.4
linux: 5.15.46-1-MANJARO

Installation Type

Linux, MacOS, or Windows Package manager (apt, pacman, eopkg, choco, brew, ...)

Operating System type and version

linux: 5.15.46-1-MANJARO

Description

Since my switch to the git-Version of flameshot (means since the last update of flameshot from my perspective of view), it's not possible anymore to remove an "pinned image" from the desktop.

Before it was easily possible if I click with the mouse on the image, and press ESC, but this don't work anymore.

Steps to reproduce

  1. run flameshot
  2. make a screenshot
  3. pin it to desktop
  4. make another screenshot
  5. take it to clipboard (CRTL+C)
  6. Try to close the pinned image (you only archive this by killing flameshot)

Screenshots or screen recordings

Nothing to show

System Information

Linux (see above)
KDE / Xorg
Monitors: 2
0: +*VGA1 1920/530x1080/300+0+0 VGA1
1: +LVDS1 1920/380x1080/210+1920+0 LVDS1

@xstable xstable added the Unconfirmed Bug The bug is not confirmed by anyone else. label Jun 16, 2022
@xstable
Copy link
Author

xstable commented Jun 16, 2022

Additional information:

I've accidentally double-click some seconds ago on such an "pinned image", and it closed.

So did you change the behavior for closing an pinned image, or is it a bug, that single-click on image followed by ESC doesn't work anymore?

@mmahmoudian
Copy link
Member

@xstable
I don't remember when the Esc was removed, but double-click for closing was always an option (case and point)

@borgmanJeremy do you recall when the Esc was removed?

@xstable
Copy link
Author

xstable commented Jun 16, 2022

Ok, thanks. Never know, that double-click exist for that :)

BTW: Then there is an inconsistency, because if you only Pin an Image to the desktop, and don't do another flameshot-screenshot afterwards, ESC still works to close the pinned image.

The new behavior only happend if you pin an image to desktop, create a new screenshot which include this pinned image, and try to remove the pinned image afterwards.

@borgmanJeremy
Copy link
Contributor

I've always used double click and not esc to close. Since I never tracked closing with esc as a feature I'm not sure when the behavior changed.

@mmahmoudian
Copy link
Member

BTW: Then there is an inconsistency, because if you only Pin an Image to the desktop, and don't do another flameshot-screenshot afterwards, ESC still works to close the pinned image.

At least on my setup that is not the case. Esc does not work at all under any circumstances using Flameshot v12.0.0 (55ba195)

@xstable
Copy link
Author

xstable commented Jun 16, 2022

Do you also use Linux & KDE?

flameshot issue_Peek 2022-06-16 14-41

Sorry for the flickering of the record. Don't know what that strange issue with the recorder is

image

@mmahmoudian
Copy link
Member

Do you also use Linux & KDE?

Yes, Manjaro KDE X11

Sorry for the flickering of the record. Don't know what that strange issue with the recorder is

use peek. The end of the video is not comprehensible. I don't understand what you are trying to achieve.

Regarding the config window screenshot you sent with blue arrows, yes, the Esc is set to cancel taking a screenshot, not to close the pinned image.

@mmahmoudian mmahmoudian added the Waiting For Info Addressing the issue or merging the PR is halted and we are waiting for more info to be provided. label Jun 17, 2022
@borgmanJeremy
Copy link
Contributor

After more consideration I dont think this is a bug. It can be double clicked to close and there is another issue opened to add close to the menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unconfirmed Bug The bug is not confirmed by anyone else. Waiting For Info Addressing the issue or merging the PR is halted and we are waiting for more info to be provided.
Projects
None yet
Development

No branches or pull requests

3 participants