Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning is impossible with "Close after capture" #964

Closed
mmahmoudian opened this issue Sep 23, 2020 · 5 comments
Closed

Pinning is impossible with "Close after capture" #964

mmahmoudian opened this issue Sep 23, 2020 · 5 comments
Labels
Bug It's a bug

Comments

@mmahmoudian
Copy link
Member

Flameshot version
Flameshot v0.8.0
Compiled with Qt 5.15.0
flameshot-git r681.def8ce2-1 AUR

Describe the bug
When the "Close after capture" is on, pinning the screenshot is impossible as the Flameshot terminates after taking the screenshot and before displaying the pinned image.

To Reproduce
"Close after capture" is on and try to pin a selected area.

Expected behavior
I expect the Flameshot to gets terminated after I close the pinned window.

System Information
Operating System: Manjaro Linux
KDE Plasma Version: 5.19.5
KDE Frameworks Version: 5.73.0
Qt Version: 5.15.0
Kernel Version: 5.8.6-1-MANJARO
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7-4770K CPU @ 3.50GHz
Memory: 15.5 GiB of RAM
Graphics Processor: Mesa DRI Intel® HD Graphics 4600

@borgmanJeremy
Copy link
Contributor

Is this even a bug? The feature is close after capture so I would expect this.

@mmahmoudian
Copy link
Member Author

@borgmanJeremy I think this is a logical bug, in the sense that it obstructs/glitches out a behavior in the software (pinning). I think there are two ways to address this:

  1. not to show the tools that "close after capture" would affect them if the "close after capture" is on
  2. Flameshot stays running as long as the pinned window is not closed by user

I personally vote for the latter.

@borgmanJeremy
Copy link
Contributor

I want to delete th close after capture feature 😁...so many confusing interactions

@mmahmoudian
Copy link
Member Author

@borgmanJeremy I don't have very strong feeling about it. If you have doubts, we can have poll to have the final verdict.

But in general from the issues I have seen and personal experience, if:

  1. the "close after capture" is disabled by default and
  2. we have a rule that add certain tools to the chain of action so that the application termination happens after them
    then the "close after capture" should not be an issue anymore.

@borgmanJeremy
Copy link
Contributor

Close after catpure is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug It's a bug
Projects
None yet
Development

No branches or pull requests

2 participants