Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11Y] New reply counter is focusable when not acting as a button #2664

Closed
Tracked by #3360
davwheat opened this issue Mar 7, 2021 · 0 comments · Fixed by #3090
Closed
Tracked by #3360

[A11Y] New reply counter is focusable when not acting as a button #2664

davwheat opened this issue Mar 7, 2021 · 0 comments · Fixed by #3090
Assignees
@davwheat
Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.)
Milestone
1.2

Comments

@davwheat
Copy link
Member

davwheat commented Mar 7, 2021

Bug Report

Current Behavior
The reply counter is focusable when 0 new replies are present.

image

Possible solutions

  1. Remove tabindex="0" when the new reply count is 0.
  2. Change to button element (also allows a11y tech to actually press it in the first place), and use the more syntactically correct disabled` prop.
@davwheat davwheat changed the title [A11Y] New reply counter is focus-able when not acting as a button [A11Y] New reply counter is focusable when not acting as a button Mar 7, 2021
@davwheat davwheat added the type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) label Mar 15, 2021
@davwheat davwheat added this to the 0.1 milestone Mar 16, 2021
@askvortsov1 askvortsov1 modified the milestones: 1.0, 1.1 Apr 16, 2021
@askvortsov1 askvortsov1 modified the milestones: 1.1, 1.2 Sep 28, 2021
@SychO9 SychO9 added this to Roadmap Oct 1, 2021
@davwheat davwheat mentioned this issue Oct 2, 2021
Merged
1 task
@SychO9 SychO9 removed this from the 1.2 milestone Oct 2, 2021
@davwheat davwheat added this to the 1.2 milestone Oct 2, 2021
Repository owner moved this from Todo to Done in Roadmap Oct 27, 2021
@SychO9 SychO9 removed this from Roadmap Nov 1, 2021
@davwheat davwheat mentioned this issue Mar 28, 2022
Open
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davwheat davwheat

Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.)
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

[A11Y] Improve accessibility for discussion reply count on post stream flarum/framework
3 participants
@davwheat @SychO9 @askvortsov1